pflib-net.Tests/dice/DiceTest.cs

@@ -49,10 +49,9 @@ public class DiceTest
     }
 
     [Test]
-    [TestCase(1, 1)]
+    public void CannotSetKeepHighestAndKeepLowest()
-    public void CannotSetKeepHighestAndKeepLowest(int high, int low)
     {
-        var e = Assert.Throws<InvalidOperationException>(
+        Assert.Throws<InvalidOperationException>(
-            () => new Dice(1, 40, high, low));
+            () => new Dice(1, 40, 1, 1));
     }
 }

pflib-net/dice/Dice.cs

@@ -7,6 +7,7 @@ public struct Dice
     private int KeepHighest { get; set; }
     private int KeepLowest { get; set; }
     private int Add { get; set; }
+    private static readonly Random Random = new();
 
     public Dice(int size, int count = 1, int keepHighest = 0, int keepLowest = 0, int add = 0)
     {
@@ -24,11 +25,10 @@ public struct Dice
 
     public int GetValue()
     {
-        var random = new Random();
         var rolls = new List<int>();
         for (var i = 0; i < Count; i++)
         {
-            rolls.Add(random.Next(Size) + 1);
+            rolls.Add(Random.Next(Size) + 1);
         }
         rolls.Sort();
 
@@ -37,7 +37,6 @@ public struct Dice
             var repeats = Count - KeepHighest;
             for (var i = 0; i < repeats; i++)
             {
-                Console.WriteLine("Removing max");
                 rolls.Remove(rolls.Max());
             }
         }
@@ -48,7 +47,6 @@ public struct Dice
             
             for (var i = 0; i < repeats; i++)
             {
-                Console.WriteLine("Removing min");
                 rolls.Remove(rolls.Min());
             }
         }